Skip to content

Commit

Permalink
crypto: cryptd - Fix skcipher instance memory leak
Browse files Browse the repository at this point in the history
cryptd_skcipher_free() fails to free the struct skcipher_instance
allocated in cryptd_create_skcipher(), leading to a memory leak.  This
is detected by kmemleak on bootup on ARM64 platforms:

 unreferenced object 0xffff80003377b180 (size 1024):
   comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s)
   backtrace:
     kmem_cache_alloc_trace+0x270/0x2d0
     cryptd_create+0x990/0x124c
     cryptomgr_probe+0x5c/0x1e8
     kthread+0x258/0x318
     ret_from_fork+0x10/0x1c

Fixes: 4e0958d ("crypto: cryptd - Add support for skcipher")
Cc: <[email protected]>
Signed-off-by: Vincent Whitchurch <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
vwax authored and herbertx committed Jul 3, 2019
1 parent c8ea9fc commit 1a0fad6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crypto/cryptd.c
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ static void cryptd_skcipher_free(struct skcipher_instance *inst)
struct skcipherd_instance_ctx *ctx = skcipher_instance_ctx(inst);

crypto_drop_skcipher(&ctx->spawn);
kfree(inst);
}

static int cryptd_create_skcipher(struct crypto_template *tmpl,
Expand Down

0 comments on commit 1a0fad6

Please sign in to comment.