Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error message when fail to get keys from torus.js #310

Merged
merged 1 commit into from
Mar 15, 2024
Merged

improve error message when fail to get keys from torus.js #310

merged 1 commit into from
Mar 15, 2024

Conversation

tanguyenvn
Copy link
Contributor

BEFORE

  • Custom Auth error
    image
  • Auth service error
    image

AFTER

  • Custom Auth error
    image
  • Auth service error
    image

tanguyenvn
tanguyenvn commented Mar 13, 2024
View reviewed changes
src/utils/error.ts
@@ -0,0 +1,26 @@
export const serializeError = async (error: unknown): Promise<Error> => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this method from Auth service

chaitanyapotti
chaitanyapotti approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 4dd6842 into master Mar 15, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/improve-error-msg branch March 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanguyenvn @chaitanyapotti