Remove obsolete loop._selector #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop._selector was introduced in commit 40f4945 with the ability to provide loop to the initializer. At that point, the loop was BaseSelectorEventLoop, which has a private _selector property. In 743795d the BaseSelectorEventLoop was replaced by AbstractEventLoop, but the _selector artefact remains. The problem can be easily identified, when you use uvloop, which implements AbstractEventLoop and is not a SelectorEventLoop. Resolves: tortoise#532 See also: tortoise#533
|
Could someone with admin rights on the repo, rerun the checks? The CI stalled for some reason, but I am pretty sure, that they should all pass. |
|
OK |
|
Thanks. This is strange, it is hanging again... |
|
Did you run |
|
I was just running the make commands as you answered. It fails on master, develop and of course on my branch with the same issue: But this should emit an error in the ci and not make it hang. |
|
You can merge develop branch first |
What do you mean? I've ran the tests on the develop branch directly. They fail there the exact same way. I've updated my develop from the upstream repo to it's latest state too, and nothing changed. I would tell, that something in my environment is odd, if you cannot reproduce it, but why the CI is failing although then? And all this to just remove 4 obsolete lines of code :) |
|
I've tested this patch locally and it means I can use |
|
Running the tests locally pass using python 3.10.6, I haven't tried earlier versions. |
|
Duplicated these changes in #1636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove obsolete loop._selector from contrib/test
Motivation and Context
The loop._selector was introduced in commit 40f4945 with the ability to provide loop to the initializer. At that point, the loop was BaseSelectorEventLoop, which has a private _selector property.
In 743795d the BaseSelectorEventLoop was replaced by AbstractEventLoop, but the _selector artefact remains.
The problem can be easily identified, when you use uvloop, which implements AbstractEventLoop and is not a SelectorEventLoop.
Resolves: #532
See also: #533
How Has This Been Tested?
I've tested it manually with an uvloop.Loop and it seems to work properly.
Checklist: