Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename pypika to pypika_tortoise #1829

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Dec 27, 2024

Description

Fixes #1300

TODO

  • Change version constraint from pypika-tortoise to ^0.4.0 in pyproject.toml after it released

Motivation and Context

Upgrade pypika-tortoise to ^0.4.0, which rename package name from pypika to pypika_tortoise

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Dec 27, 2024

Pull Request Test Coverage Report for Build 12515648841

Details

  • 64 of 64 (100.0%) changed or added relevant lines in 31 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.251%

Totals Coverage Status
Change from base Build 12506053021: 0.0%
Covered Lines: 6403
Relevant Lines: 6981

💛 - Coveralls

@waketzheng waketzheng marked this pull request as ready for review December 27, 2024 11:56
@waketzheng waketzheng requested review from henadzit and abondar and removed request for henadzit December 27, 2024 11:56
@waketzheng waketzheng merged commit 968d0d5 into tortoise:develop Dec 27, 2024
8 checks passed
@henadzit
Copy link
Contributor

@waketzheng sorry for being late on this.

I think we also should do two things:

  • Update docs, pypika is referenced in functions.rst and indexes.rst
  • We need to do a major release with these changes because they might be breaking for people who have custom functions and indexes because they might reference code from pypika.

@waketzheng
Copy link
Contributor Author

@henadzit
I think a minor release(0.24.0) with breaking change description in release note is enough.

@henadzit
Copy link
Contributor

@henadzit I think a minor release(0.24.0) with breaking change description in release note is enough.

sorry, I mixed up minor and major. I agree, minor should be enough!

@waketzheng waketzheng deleted the rename-pypika branch January 3, 2025 07:45
@henadzit henadzit mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import name 'ClickHouseQuery' from 'pypika.dialetcs'
4 participants