Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug combined expression connectors #1794

Merged

Conversation

Abdeldjalil-H
Copy link
Contributor

@Abdeldjalil-H Abdeldjalil-H commented Dec 1, 2024

This PR changes expressions.Connector values to be explicit strings. This is because the operator module does not have a function called div (it is truediv).

Motivation and Context

We use enum values instead of names to get the operator function from operator module.

How Has This Been Tested?

Running existing tests.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12106864031

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.282%

Totals Coverage Status
Change from base Build 12072061244: 0.0%
Covered Lines: 6305
Relevant Lines: 6877

💛 - Coveralls

Copy link
Contributor

@henadzit henadzit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@henadzit henadzit merged commit b382b8c into tortoise:develop Dec 1, 2024
7 checks passed
@henadzit henadzit mentioned this pull request Dec 8, 2024
@Abdeldjalil-H Abdeldjalil-H deleted the fix-bug-combined-expression branch December 19, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants