Primary key field should not be nullable #1778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary key field should not be nullable
Description
If a value is a primary key, it should not be optional(nullable). For example, there is a Model called
Foo
, whose primary key is aUUIDField
calledid
. Submitting a form usingFooIn
will useexclude_readonly=True
, so theid
field will not be included. And for outputFooOut
id cannot be nullable because it is the primary key. This PR fixes this problem.Before:
After:
Motivation and Context
My projects use OpenAPI documentation auto-generated as a TypeScript client. It helps a lot to annotate the types correctly.
How Has This Been Tested?
This is a minor change, and it passes all existing tests. I tested it in a few of my live projects and it works fine.
Checklist: