Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blacksheep example unittest error (#1534) #1539

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Jan 4, 2024

Description

Motivation and Context

The document of blacksheep suggests to use pytest_asyncio for async test,
so I add it to dev group, and change _tests.py to be in accordance with blacksheep's demo.

How Has This Been Tested?

make test
cd examples/blacksheep && PYTHONPATH=. poetry run pytest _tests.py

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@abondar
Copy link
Member

abondar commented Apr 26, 2024

We should also rebase this to actual, but may be after merging #1540

@waketzheng waketzheng force-pushed the upgrade-blacksheep-to-v2 branch from d85f08a to b2b9b6c Compare April 27, 2024 08:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8863610731

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 87.934%

Files with Coverage Reduction New Missed Lines %
tortoise/models.py 7 97.24%
tortoise/queryset.py 27 94.58%
Totals Coverage Status
Change from base Build 8858003658: 0.03%
Covered Lines: 5771
Relevant Lines: 6467

💛 - Coveralls

@waketzheng
Copy link
Contributor Author

@abondar done.

@abondar abondar merged commit 986e1b2 into tortoise:develop Apr 28, 2024
7 checks passed
@waketzheng waketzheng deleted the upgrade-blacksheep-to-v2 branch May 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants