Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sample Quart integration #121

Merged
merged 7 commits into from
Apr 8, 2019
Merged

[WIP] Sample Quart integration #121

merged 7 commits into from
Apr 8, 2019

Conversation

grigi
Copy link
Member

@grigi grigi commented Apr 2, 2019

Sample Quart integration

@grigi grigi requested a review from abondar April 2, 2019 19:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 501: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 501: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@grigi grigi changed the title Very simple Quart example [WIP] Sample Quart integration Apr 3, 2019
examples/quart_example.py Outdated Show resolved Hide resolved
@pgjones
Copy link

pgjones commented Apr 3, 2019

It tortoise asyncio only or can Trio be used? If the latter is possible it might be nice to provide an example that could work with either (quart-trio also exists).

Thanks for adding a Quart example 🎉

@grigi
Copy link
Member Author

grigi commented Apr 4, 2019

I doubt Trio will work anytime soon. We use asyncio directly in a few places, and I suspect we may run into issues with the DB drivers.

@grigi grigi mentioned this pull request Apr 8, 2019
72 tasks
@pgjones
Copy link

pgjones commented Apr 8, 2019

👍 Looks good to me.

@grigi grigi merged commit db3818b into master Apr 8, 2019
@grigi grigi deleted the quart_example branch April 16, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants