Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling for the UDP tracker #747

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Profiling for the UDP tracker #747

merged 3 commits into from
Mar 20, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Mar 20, 2024 •
edited
Loading

Profiling for the UDP tracker.

  • Add a new binary for profiling.
  • Minor refactorings. Rename functions and extract named closures.

@josecelano josecelano added the Optimization Make it Faster label Mar 20, 2024
@josecelano josecelano marked this pull request as draft March 20, 2024 11:22
@josecelano josecelano linked an issue Mar 20, 2024 that may be closed by this pull request
Profiling for the UDP Tracker #746
Closed
@josecelano josecelano force-pushed the 746-profiling-for-the-udp-tracker branch from 810e59a to cc1cbc1 Compare March 20, 2024 11:24
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.72%. Comparing base (b777d3a) to head (9015668).

Files Patch % Lines
src/servers/udp/server.rs 74.07% 7 Missing ⚠️
src/console/profiling.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #747      +/-   ##
===========================================
- Coverage    73.74%   73.72%   -0.02%     
===========================================
  Files          144      145       +1     
  Lines         8980     8987       +7     
===========================================
+ Hits          6622     6626       +4     
- Misses        2358     2361       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano marked this pull request as ready for review March 20, 2024 14:05
@josecelano
Copy link
Member Author

ACK 9015668

@josecelano josecelano requested a review from da2ce7 March 20, 2024 14:05
@josecelano josecelano removed a link to an issue Mar 20, 2024
Profiling for the UDP Tracker #746
Closed
@josecelano josecelano merged commit ea33f1c into torrust:develop Mar 20, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees
No one assigned
Labels
Optimization Make it Faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josecelano