-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Service Initialization #561
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #561 +/- ##
===========================================
+ Coverage 79.25% 80.68% +1.43%
===========================================
Files 117 117
Lines 7711 7816 +105
===========================================
+ Hits 6111 6306 +195
+ Misses 1600 1510 -90 ☔ View full report in Codecov by Sentry. |
b53a219
to
108e3b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @da2ce7 I've only added a couple of comments. Regarding my comments on configuration it's something to consider for future bif refactors in configuration.
108e3b5
to
b6ce640
Compare
b6ce640
to
a12fdee
Compare
ACK a12fdee |
a12fdee
to
13140f6
Compare
ACK 13140f6 |
Extracted from:
Closes #560