Publish docker image only when secrets are available #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since dockerhun does not allow scoepd token, we are going to use forks to publish docker images. The "publisher" can set their token on their forks. The workflow is executed only if the secret "DOCKER_HUB_USERNAME" is set in the environment "dockerhub-torrust"
da2ce7
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #132 (reply in thread)
https://hub.docker.com/ does not have scoped tokens. They only have personal tokens. If you want to deploy the docker image with a workflow, you have to use your personal token.
To avoid sharing your personal tokens with all the maintainers, we agreed on using forks. I've changed the workflow. now it is only executed if the secret "DOCKER_HUB_USERNAME" is set in the "dockerhub-torrust" environment.
We can disable the workflow in this repo just by deleting the env vars:
I only check for
DOCKER_HUB_USERNAME.We can use the same approach for publishing the crate on https://crates.io