Extract duplicate code into new package: `bittorrent-http-protocol` #1112

josecelano · 2024-11-29T16:41:43Z

For now, it only contains percent encoding functions.

This removes duplicate code and fixes the problem of slow doc tests. On my machine, it takes 40 seconds to run all doc tests with one job.

time cargo test --doc --workspace --jobs=1

real    0m40.443s
user    6m6.863s
sys     0m22.609s

I have also fixed the testing workflow, it was using cargo test --doc to run doc-tests without including doc-test is workspace packages.

in the workspace.

josecelano · 2024-11-29T17:17:15Z

josecelano added 3 commits November 29, 2024 16:31

fix: [torrust#1097] by extracting duplicate module

555d5b8

fix: doc tests

c61cc9a

ci: fix testing workflow. Run doc tests for all packages

39716a8

in the workspace.

josecelano requested a review from a team as a code owner November 29, 2024 16:41

josecelano self-assigned this Nov 29, 2024

josecelano linked an issue Nov 29, 2024 that may be closed by this pull request

Some docs tests are very slow #1097

Closed

josecelano requested a review from da2ce7 November 29, 2024 16:41

josecelano had a problem deploying to coverage November 29, 2024 16:41 — with GitHub Actions Failure

josecelano added 2 commits November 29, 2024 17:12

fix: cargo machete warning

a62ae82

test: add test for percent_encode_byte_array

2bc44af

josecelano had a problem deploying to coverage November 29, 2024 17:13 — with GitHub Actions Failure

josecelano merged commit 17e86c6 into torrust:develop Nov 29, 2024
20 of 21 checks passed

josecelano removed a link to an issue Dec 18, 2024

Some docs tests are very slow #1097

Closed

Provide feedback