Refactor: extract duplicate implementation of InfoHash struct
#756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To replace the `InfoHash` type with the one in this new dep.
The `InfoHash` struct has been extracted into a new crate to be reused in other projects like the Torrust Tracker: https://github.com/torrust/bittorrent-primitives
|
ACK 569fbd2 |
It was used but the `info_hash` module that has been extracted into a new package: https://github.com/torrust/bittorrent-primitives
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #756 +/- ##
===========================================
- Coverage 40.05% 39.21% -0.85%
===========================================
Files 117 116 -1
Lines 7212 7074 -138
===========================================
- Hits 2889 2774 -115
+ Misses 4323 4300 -23 ☔ View full report in Codecov by Sentry. |
josecelano
added a commit
to torrust/torrust-tracker
that referenced
this pull request
Oct 31, 2024
… struct 7fe648c refactor: replace InfoHash with external extracted crate (Jose Celano) 7d7dba5 feat: add dep bittorrent-primitives (Jose Celano) Pull request description: Relates to: - torrust/torrust-index#251 - torrust/torrust-index#756 The `InfoHash` type was duplicated here and in the [Index](torrust/torrust-index#251). I've extracted it into a new crate. I'm planning to move the very basic types that we are using in other projects. I'm also planning to extract more packages like: - UDP tracker client - HTTP tracker client - Tracker console client (after merging UDP console client, HTTP console client and Tracker checker). See #669 Some of those new packages also depend on this new [bittorrent-primitives](https://github.com/torrust/bittorrent-primitives) crate. ACKs for top commit: josecelano: ACK 7fe648c Tree-SHA512: 3ab5b2ef8631ae72b792dea6b1c9ab1e64b28f170d4580109872739427f0f50ae753af014d691e41bdffbf3a33da732cba89fd1487b9e219345e74b15599b1b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
InfoHashstruct torrust-tracker#360InfoHashstruct torrust-tracker#1066The
InfoHashtype was duplicated here and in the Tracker. I've extracted it into a new crate:https://github.com/torrust/bittorrent-primitives