Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secrets in config options mandatory #713

Conversation

josecelano
Copy link
Member

Make secrets in config options mandatory:

  • tracker.token
  • auth.user_claim_token_pepper

It keeps the SMPT server credentials default because they are not always needed:

  • mail.smpt.credentials.password

For example, for the mailcatcher.

@josecelano josecelano self-assigned this Aug 12, 2024
@josecelano josecelano added the - System Admin - Enjoyable to Install and Setup our Software label Aug 12, 2024
@josecelano josecelano added this to the v3.0.0 milestone Aug 12, 2024
@josecelano josecelano requested a review from da2ce7 August 12, 2024 12:04
@josecelano josecelano marked this pull request as ready for review August 12, 2024 12:08
@josecelano josecelano linked an issue Aug 12, 2024 that may be closed by this pull request
- `tracker.token`
- `auth.user_claim_token_pepper`

It keeps the default for the SMPT server credential ebcuase they are not
always needed.

- `mail.smpt.credentials.password`
This changes were missing when the issue was implemented.

See torrust#653.
@josecelano josecelano force-pushed the 710-config-overhaul-make-secrets-mandatory branch from bf3759f to cb0e375 Compare August 12, 2024 12:31
@josecelano
Copy link
Member Author

ACK cb0e375

@josecelano josecelano merged commit 8156fd8 into torrust:develop Aug 12, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- System Admin - Enjoyable to Install and Setup our Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config overhaul: make secrets mandatory
1 participant