Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code owners for GitHub workflows #101

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Add code owners for GitHub workflows #101

merged 1 commit into from
Apr 21, 2023

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Apr 14, 2023

@da2ce7 @josecelano @WarmBeer get notified when a PR changes the .github dir content.

@WarmBeer, we should also enable required reviews for PR and require approval from a code owner before the author can merge a pull request in the repository.

"Optionally, you can choose to require reviews from code owners. If you do, any pull request that affects code with a code owner must be approved by that code owner before the pull request can be merged into the protected branch."

See: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-pull-request-reviews-before-merging

I don't have permission to do it.

@josecelano
Copy link
Member Author

ACK 08f0aac

@josecelano josecelano merged commit abb4e91 into torrust:develop Apr 21, 2023
@josecelano josecelano deleted the issue-30-code-owners-for-github-workflows branch April 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement a Code-owners File to restrict writing to the .github/ directory.
1 participant