Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2171: Make IOStream class configurable #2175

Closed
wants to merge 8 commits into from
Closed

Fix #2171: Make IOStream class configurable #2175

wants to merge 8 commits into from

Conversation

pitrou
Copy link
Contributor

@pitrou pitrou commented Oct 21, 2017

No description provided.

@pitrou
Copy link
Contributor Author

pitrou commented Oct 21, 2017

So the obscure Sphinx error (it seems there is a bug in Sphinx's own warning display machinery) is due to the fact that IOStream is now cross-referenced to several targets: tornado.iostream.IOStream, tornado.tcpclient.TCPClient.IOStream, tornado.tcpserver.TCPServer.IOStream. It seems other people got this issue: sphinx-doc/sphinx#3866

@pitrou pitrou mentioned this pull request Oct 22, 2017
Closed
@pitrou
Copy link
Contributor Author

pitrou commented Oct 22, 2017

I tried the Sphinx workaround mentioned in sphinx-doc/sphinx#3866 (comment) but it didn't work...

@pitrou pitrou mentioned this pull request Jan 4, 2018
Closed
@bdarnell bdarnell mentioned this pull request Apr 24, 2018
Closed
@bdarnell
Copy link
Member

Closing since you don't need this after read_into was merged, and I think when/if we do make IOStream configurable it won't be based on assignment to class-level variables.

@bdarnell bdarnell closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iostream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pitrou @bdarnell