Integrate websocket periodic pinging code from Jupyter #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes tornadowebgh-1640 As Ben requested on tornadoweb#1640, I've changed it to work in seconds rather than milliseconds. I'm not sure how we'd test something like this. I don't think we have tests for it in Jupyter.
bdarnell
reviewed
Feb 20, 2017
| since_last_pong = now - self.last_pong | ||
| since_last_ping = now - self.last_ping | ||
| if since_last_ping < 2*self.ping_interval and since_last_pong > self.ping_timeout: | ||
| self.log.warn("WebSocket ping timeout after %i ms.", since_last_pong) |
There was a problem hiding this comment.
There's no such thing as self.log.warn here.
| tornado's regular pinging may decide that the connection has dropped | ||
| and close the websocket. | ||
| """ | ||
| self.last_pong = IOLoop.current().time() |
There was a problem hiding this comment.
It's better to do this outside the overridable method so there's no question about calling the superclass method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-1640
As Ben requested on #1640, I've changed it to work in seconds rather than milliseconds.
I'm not sure how we'd test something like this. I don't think we have tests for it in Jupyter.