Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Image for easier setup #3265

Closed
Faizan-Alam-1 opened this issue May 12, 2023 · 3 comments
Closed

Add Docker Image for easier setup #3265

Faizan-Alam-1 opened this issue May 12, 2023 · 3 comments

Comments

@Faizan-Alam-1
Copy link

I would like to propose adding a Docker image to the project.

It will be easier for contributors and users to set up and run the project since they won't have to manually install dependencies.

I would be glad to work on this and create a pull request if the maintainers agree.

@bdarnell
Copy link
Member

What exactly are you thinking of here? As a library rather than an executable Tornado is not something users "run" - you use it by adding it to your own dependencies, not in an independent container.

For contributors, we do have a few dependencies (notably getting the right version of black and mypy), but in my experience it's easier to handle those with a virtualenv instead of a container (except for vscode's "devcontainer" integration, but I'd strongly prefer to keep tornado's main repos editor/tool-agnostic)

@Faizan-Alam-1
Copy link
Author

Yes you right ,
I am very new to the open source community. I used this library several times in my Django project. I really wanted to give back to the community by contribution. Could you please assign me a beginner friendly task?

@bdarnell
Copy link
Member

Over the years we've had more beginners than beginner-friendly tasks, so it might not be easy to find something appropriate. Looking back over the current list, #2935 is an easy one. Some others that should be fairly easy (but I haven't looked closely) include #2905, #2742, and #2655. Or you could go through the open issues and see if any look particularly interesting to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants