Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket: Fix ping_timeout < ping_interval #2905

Open
bdarnell opened this issue Aug 29, 2020 · 2 comments · May be fixed by #3376
Open

websocket: Fix ping_timeout < ping_interval #2905

bdarnell opened this issue Aug 29, 2020 · 2 comments · May be fixed by #3376
Labels
websocket

Comments

@bdarnell
Copy link
Member

The websocket ping implementation behaves confusingly when the ping timeout is set to less than the ping interval. It doesn't close the connection until the interval has elapsed, even if the timeout has expired.

Reported in #2886.
@bdarnell bdarnell mentioned this issue Aug 29, 2020
Closed
@joegasewicz
Copy link

Can I pick this up @bdarnell

@bdarnell
Copy link
Member Author

Yes, go ahead.

@bdarnell bdarnell mentioned this issue May 14, 2023
Closed
@oliver-sanders oliver-sanders linked a pull request May 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

websockets: fix ping_timeout oliver-sanders/tornado
2 participants
@bdarnell @joegasewicz