Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codebase #249

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Improve codebase #249

merged 5 commits into from
Mar 24, 2023

Conversation

torik42
Copy link
Owner

@torik42 torik42 commented Mar 24, 2023

This PR combines various improvements of the codebase.

  • Use absolute imports for better readability.
  • Add docstrings to yalafi for hints in IDEs and Sphinx documentation.
  • Refactor some parts for readability.
  • Remove Trailing spaces.
  • Add Pylint configuration to pyproject.toml
  • Replace bare exceptions except: with except Exception:, since “a bare except: clause will catch SystemExit and KeyboardInterrupt exceptions” (see PEP8)

torik42 added 5 commits March 24, 2023 20:49
Add configuration for Pylint to `pyproject.toml` and hide some
unnecessary warnings.
As suggested by Pylint. We still do `except Exception` since the problem
is presented to the user over stderr.
@torik42 torik42 merged commit 2ba4635 into master Mar 24, 2023
@torik42 torik42 deleted the improve-codebase branch March 24, 2023 20:34
@torik42 torik42 mentioned this pull request Mar 24, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant