Fix unexpected default nics dropdown item when creating network configuration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
changed the title
a110605
commented
Oct 22, 2024
| @@ -361,21 +361,6 @@ export default { | |||
|
|
|||
| this.nicErrors = uniq(nicErrors); | |||
| }, | |||
|
|
|||
| 'value.spec.uplink.nics'(nics = []) { | |||
There was a problem hiding this comment.
We don't need to show warning banner after selected nic. Since disabled options cannot be selected.
a110605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
:defaultAddValuewas added in this commit, the default selected item will beoption[0].valueevenoption[0].disabled = truewhich doesn't make sense to me.With torchiaf/dashboard#7 change, we can have same behavior in harvester/dashboard
Current behavior
After fix
aaa.mov