Add Django 4.2 to the testing matrix #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a more targeted fix compared to #219 It solely targets the change to support Django 4.2 and maintains the use of tox_install.sh to instsall dependencies. Inspired by |
|
@thibaudcolas or @bcdickinson can help to review this PR? Thank you |
zerolab
reviewed
May 9, 2023
| envlist = py{37,38,39,310,311}-dj{32,40,41,main}, lint | ||
| envlist = | ||
| py{37,38,39,310}-dj32 | ||
| py{38,39,310,311}-dj40 |
There was a problem hiding this comment.
it is a good time to drop Django 4.0 from the matrix
There was a problem hiding this comment.
👍 I’ll do that and Python 3.7 separately.
zerolab
reviewed
May 9, 2023
| @@ -17,6 +24,7 @@ deps = | |||
| ; Use pre-releases until stable releases are available. | |||
| ; dj42: Django==4.2a1 | |||
| ; dj42: Django>=4.2,<4.3 | |||
| dj42: Django==4.2rc1 | |||
There was a problem hiding this comment.
Suggested change
| dj42: Django==4.2rc1 | |
| dj42: Django>=4.2,<4.3 |
thibaudcolas
approved these changes
Aug 18, 2023
| envlist = py{37,38,39,310,311}-dj{32,40,41,main}, lint | ||
| envlist = | ||
| py{37,38,39,310}-dj32 | ||
| py{38,39,310,311}-dj40 |
There was a problem hiding this comment.
👍 I’ll do that and Python 3.7 separately.
thibaudcolas
changed the title
|
Thank you for this @thibaudcolas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades the support of Django to 4.2rc1
Also this is similar to #219 but continues to use tox_install.sh.
Fixes #212, #214, #218
Checklist