Implement fmod, remainder, equal in Cutorch #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
reviewed
Nov 16, 2016
| // 1 if the two tensors are equal at a position, otherwise 0. If the minimum value | ||
| // in this buffer is 1, the two tensors are equal, otherwise they are not | ||
|
|
||
| THLongStorage *size = THCTensor_(newSizeOf)(state, self_); |
There was a problem hiding this comment.
i merged this a tad bit prematurely, but ugh this is a memory leak.
you need to free size after using it
THLongStorage_free(size)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please pay special attention in review to equal. Fmod/Remainder were both similar to existing cutorch functions, they simply required new Op definitions.