Fix Sequel deprecation warnings #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sequel throws deprication warnings when using its older symbol qualifying syntax (`table__column`). Additionally, `Model.table_name` in `sequel` can return a non-`String` value. Uses `::Sequel.qualify` to join `table_name` and `column`. Uses the `Sequel::SQL::QualifiedIdentifier` returned from `Chewy::Type::Adapter::Sequel#full_column_name` appropriately in the relevant `scope` filters.
matchbookmac
changed the title
|
Awesome, thanks! |
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Sequel throws deprecation warnings when using its older symbol-splitting syntax (
:table__column).Additionally,
Model.table_nameinsequelcan return a non-String/Symbolvalue.How
Uses
::Sequel.qualifyto jointable_nameandcolumn.Uses the
Sequel::SQL::QualifiedIdentifierreturned fromChewy::Type::Adapter::Sequel#full_column_nameappropriately in the relevantscopefilters.Notes
I see there is already a PR for this (#542), but it looks like the build isn't passing.