Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'Calculator' front-end for Decodables #52

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Conversation

igorbonadio
Copy link
Member

No description provided.

@renatocf
Copy link
Member

@igorbonadio,

Before we merge it, I'd suggest just one change: change the use of double by the alias Probability. This is a better approach because it has a better semantic meaning, and if we eventually decide to change the type (for float or a multiprecision library), it will be easy to change the entire system. Also, issue #50 will introduce assertions to guarantee all Probability return are within the range [0,1].

I believe to make things even better, we should also introduce an alias Infinity, defined as std::numeric_limits<double>::infinity(). It's not only less verbose but would have the same advantages of the alias Probability. But that's a change for another issue.

@renatocf
Copy link
Member

Created: #53. As this is a simple task, we can assign it to Bruno or Ademar, or you yourself can change it quickly if you want so.

@igorbonadio
Copy link
Member Author

I tried to change all probabilities values to Probability type. In fact std::numeric_limits<double>::infinity() is std::numeric_limits<Probability>::infinity() now.

@renatocf
Copy link
Member

Perfect. We can merge it. Afterward take a look at my comments in #53. Maybe we should think in a more meaningful type system for values that will differentiate probabilities from logarithm of probabilities.

renatocf added a commit that referenced this pull request Jan 15, 2016
Implement 'Calculator' front-end for Decodables
@renatocf renatocf merged commit 87a2775 into master Jan 15, 2016
@renatocf renatocf deleted the calculator branch January 15, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants