Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ruff version for cognee #450

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: Update ruff version for cognee #450

merged 3 commits into from
Jan 17, 2025

Conversation

dexters1
Copy link
Collaborator

@dexters1 dexters1 commented Jan 17, 2025

Description

Update ruff version used for cognee to match GH action

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin

Summary by CodeRabbit

  • Tests

    • Refactored multiple test files to improve assertion readability by condensing multi-line assertions into single-line formats
    • Maintained original test logic and functionality across various document and processing test files
  • Dependency Updates

    • Updated ruff dependency version to >=0.9.2,<1.0.0

@dexters1 dexters1 self-assigned this Jan 17, 2025
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request focuses on standardizing and improving the readability of test assertion statements across multiple test files in the cognee project. The changes primarily involve reformatting assertions from multi-line to single-line formats, consolidating assertion conditions and error messages. These modifications span various test files including document-specific tests, deduplication tests, and chunk processing tests. Additionally, the pyproject.toml file was updated to upgrade the ruff dependency version.

Changes

File Path Change Summary
tests/integration/documents/*_test.py Consolidated assertion statements into single lines for AudioDocument, ImageDocument, PdfDocument, TextDocument, and UnstructuredDocument tests
tests/test_deduplication.py Reformatted assertion statements to single-line format
tests/test_falkordb.py Condensed SQLite database path assertion to single line
tests/test_library.py Simplified database path assertion formatting
tests/test_pgvector.py Converted multiline assertions to single-line format
tests/unit/processing/chunks/*_test.py Reformatted assertions in chunk processing test files
pyproject.toml Updated ruff dependency version from >=0.2.2,<0.9.0 to >=0.9.2,<1.0.0

Possibly related PRs

Suggested reviewers

  • hajdul88

Poem

🐰 Assertions dancing, line by line,
Code gets cleaner, looking so fine!
Single statements, crisp and bright,
Readability leaps to a new height!
Rabbit's code review, with a cheerful grin 🧐


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65a0c98 and be2aa99.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (14)
  • cognee/tests/integration/documents/AudioDocument_test.py (1 hunks)
  • cognee/tests/integration/documents/ImageDocument_test.py (1 hunks)
  • cognee/tests/integration/documents/PdfDocument_test.py (1 hunks)
  • cognee/tests/integration/documents/TextDocument_test.py (1 hunks)
  • cognee/tests/integration/documents/UnstructuredDocument_test.py (1 hunks)
  • cognee/tests/test_deduplication.py (2 hunks)
  • cognee/tests/test_falkordb.py (1 hunks)
  • cognee/tests/test_library.py (1 hunks)
  • cognee/tests/test_pgvector.py (2 hunks)
  • cognee/tests/unit/processing/chunks/chunk_by_paragraph_2_test.py (3 hunks)
  • cognee/tests/unit/processing/chunks/chunk_by_paragraph_test.py (1 hunks)
  • cognee/tests/unit/processing/chunks/chunk_by_sentence_test.py (2 hunks)
  • cognee/tests/unit/processing/chunks/chunk_by_word_test.py (1 hunks)
  • pyproject.toml (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dexters1 dexters1 marked this pull request as ready for review January 17, 2025 09:40
@dexters1 dexters1 requested a review from Vasilije1990 January 17, 2025 09:43
@Vasilije1990 Vasilije1990 merged commit 70e68fe into dev Jan 17, 2025
27 checks passed
@Vasilije1990 Vasilije1990 deleted the ruff-version branch January 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants