Fix: Fixes logging setup #434
Conversation
WalkthroughThe pull request introduces changes to the logging configuration in the project. The Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This is just a quick fix for logging. Due to other code changes, the last solution no longer works. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cognee/shared/utils.py (1)
Line range hint
487-563: Clean up example code for better clarity.The example is helpful but could be improved by:
- Removing the commented out code that duplicates functionality
- Consistently using async/await patterns
Apply this diff to clean up the example:
- # Call the function - # output_html = await create_cognee_style_network_with_logo( - # G=G, - # output_filename="example_network.html", - # title="Example Cognee Network", - # node_attribute="group", # Attribute to use for coloring nodes - # layout_func=nx.spring_layout, # Layout function - # layout_scale=3.0, # Scale for the layout - # logo_alpha=0.2, # Transparency of the logo - # ) - # Create a random geometric graph - # G = nx.random_geometric_graph(50, 0.3) - # Assign random group attributes for coloring - # for i, node in enumerate(G.nodes()): - # G.nodes[node]["group"] = f"Group {i % 3 + 1}" - # - # create_cognee_graph( - # G, - # output_filename="cognee_style_network_with_logo.html", - # title="Cognee-Graph Network", - # node_attribute="group", - # layout_func=nx.spring_layout, - # layout_scale=3.0, # Replace with your logo file path - # )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
cognee/shared/utils.py(1 hunks)examples/python/dynamic_steps_example.py(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/python/dynamic_steps_example.py
⏰ Context from checks skipped due to timeout of 90000ms (18)
- GitHub Check: run_notebook_test / test
- GitHub Check: run_notebook_test / test
- GitHub Check: run_simple_example_test / test
- GitHub Check: run_dynamic_steps_example_test / test
- GitHub Check: run_notebook_test / test
- GitHub Check: run_multimedia_example_test / test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: test
- GitHub Check: profiler
- GitHub Check: docker-compose-test
- GitHub Check: Publish Cognee Docker image
🔇 Additional comments (1)
cognee/shared/utils.py (1)
471-484: LGTM! The logging setup has been improved.The changes enhance the logging configuration by:
- Preventing duplicate handlers through explicit cleanup
- Using a consistent formatter for all logs
- Properly managing the root logger
Summary by CodeRabbit