Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #114

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Update Dockerfile #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c151b0
Update Dockerfile
Vasilije1990 Jun 24, 2024
6862822
Update Dockerfile
Vasilije1990 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,6 @@ COPY cognee/ /app/cognee
COPY entrypoint.sh /app/entrypoint.sh
RUN chmod +x /app/entrypoint.sh

RUN sed -i 's/\r$//' /app/entrypoint.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidate RUN instructions for better layer optimization.

Given the multiple RUN instructions in the Dockerfile, consider combining them where feasible to reduce the number of layers, which can improve build performance and reduce the image size.

- RUN chmod +x /app/entrypoint.sh
- RUN sed -i 's/\r$//' /app/entrypoint.sh
+ RUN chmod +x /app/entrypoint.sh && \
+    sed -i 's/\r$//' /app/entrypoint.sh
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RUN sed -i 's/\r$//' /app/entrypoint.sh
RUN chmod +x /app/entrypoint.sh && \
sed -i 's/\r$//' /app/entrypoint.sh
Tools
Hadolint

[info] 30-30: Multiple consecutive RUN instructions. Consider consolidation. (DL3059)


ENTRYPOINT ["/app/entrypoint.sh"]
Loading