Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PriorityClassName and Affinity #285

Merged

Conversation

josephangbc
Copy link
Contributor

closes #284

@josephangbc josephangbc marked this pull request as ready for review October 26, 2024 16:04
@josephangbc josephangbc requested a review from a team as a code owner October 26, 2024 16:04
Copy link
Contributor

@toshipp toshipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good. I left some comments, please check it.

charts/pvc-autoresizer/values.yaml Outdated Show resolved Hide resolved
charts/pvc-autoresizer/values.yaml Outdated Show resolved Hide resolved
@josephangbc josephangbc requested a review from toshipp October 28, 2024 11:01
@toshipp
Copy link
Contributor

toshipp commented Oct 29, 2024

@josephangbc
Could you re-generate charts/pvc-autoresizer/README.md?
The instruction is make generate-helm-docs. If you didn't setup tools, please make setup first.

Signed-off-by: Joseph Ang <[email protected]>
@josephangbc josephangbc force-pushed the add-priorityclassname-and-affinity branch from 87cccef to 3763af2 Compare October 29, 2024 16:35
@satoru-takeuchi satoru-takeuchi merged commit 25a0c93 into topolvm:main Oct 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add PriorityClassName and Affinity to Helm Deployment Template
3 participants