Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for K8s metrics API as a source of PVC usage data #241

Closed
wants to merge 0 commits into from

Conversation

tropnikovvl
Copy link
Contributor

Hello!

I was previously interested in the possibility of using a pvc-autoresizer without Prometheus and was given the answer that there had already been an attempt to do this.

I'm restarting this effort because I think it's important for users and I tried to take into account all your comments.

@llamerada-jp
Copy link
Contributor

Commits merged before are mixed in this PR. Could you please clean this up by using rebase or otherwise?

@tropnikovvl
Copy link
Contributor Author

Commits merged before are mixed in this PR. Could you please clean this up by using rebase or otherwise?

Done

@ushitora-anqou
Copy link
Contributor

ushitora-anqou commented Feb 6, 2024

Hi. Could you combine your commits into one? Currently, your PR has two separate commits (see here).

Also, please only include a description of your changes in the commit message. It currently contains irrelevant messages (see here).

@tropnikovvl
Copy link
Contributor Author

tropnikovvl commented Feb 6, 2024

I'm sorry, but I accidentally destroyed all my work with a rebase.

New PR - #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants