proposal: Expand the PVC's initial capacity based on the largest capacity in specified PVCs. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamerada-jp
force-pushed
the
proposal-resize-by-group
branch
3 times, most recently
from
872b1b0 to
29a2339
Compare
toshipp
requested review from
peng225 and
satoru-takeuchi
and removed request for
pluser and
satoru-takeuchi
peng225
reviewed
Feb 2, 2023
daichimukai
reviewed
Feb 6, 2023
|
|
||
| Rules for grouping & initial sizing | ||
|
|
||
| - If creating a PVC has a `resize.topolvm.io/pre-resize-group-by` annotation and the label specified in the annotation exists, existing PVCs with matching values are determined to be in the same group. |
There was a problem hiding this comment.
IMHO, the name resize.topolvm.io/pre-resize-group-by is ambiguous because it is not clear what pre refers to.
There was a problem hiding this comment.
@peng225 @daichimukai @satoru-takeuchi
How about resize.topolvm.io/init-resize-group-by or resize.topolvm.io/initial-resize-group-by ?
There was a problem hiding this comment.
I prefer resize.topolvm.io/initial-resize-group-by.
There was a problem hiding this comment.
I agree with @peng225 and @daichimukai
peng225
reviewed
Feb 8, 2023
|
|
||
| Rules for grouping & initial sizing | ||
|
|
||
| - If creating a PVC has a `resize.topolvm.io/pre-resize-group-by` annotation and the label specified in the annotation exists, existing PVCs with matching values are determined to be in the same group. |
There was a problem hiding this comment.
I prefer resize.topolvm.io/initial-resize-group-by.
llamerada-jp
force-pushed
the
proposal-resize-by-group
branch
from
ed4dd6a to
8474139
Compare
peng225
reviewed
Feb 13, 2023
Signed-off-by: Yuji Ito <[email protected]> Co-authored-by: Shinya Hayashi <[email protected]>
llamerada-jp
force-pushed
the
proposal-resize-by-group
branch
from
9dc212f to
539ece4
Compare
peng225
previously approved these changes
Feb 14, 2023
Comment on lines
9
to
12
| One use case for pvc-autoresizer is automatically expanding a PV/PVC for multiple Pod/PV pairs, such as a MySQL cluster. | ||
| In such a cluster, if a Pod/PV fails and a PV/PVC is rebuilt by the restore process, a PV is created based on the PVC template. Even if a PV of the same size as the others is actually needed, a PV of the template's capacity is created. As a result, the restore process stops due to insufficient capacity. | ||
|
|
||
| To solve this problem, we are planning to add a new feature to create a PV/PVC with sufficient capacity when PVCs of the same group already exist. |
There was a problem hiding this comment.
Suggested change
| One use case for pvc-autoresizer is automatically expanding a PV/PVC for multiple Pod/PV pairs, such as a MySQL cluster. | |
| In such a cluster, if a Pod/PV fails and a PV/PVC is rebuilt by the restore process, a PV is created based on the PVC template. Even if a PV of the same size as the others is actually needed, a PV of the template's capacity is created. As a result, the restore process stops due to insufficient capacity. | |
| To solve this problem, we are planning to add a new feature to create a PV/PVC with sufficient capacity when PVCs of the same group already exist. | |
| Sometimes we needs to resize multiple PVCs at once. It typicall happens in StatefulSet. Here is the examples in MySQL clusters created by [moco](https://github.com/cybozu-go/moco). | |
| 1. Moco creates a StatefulSet to manage a MySQL cluster. In addition, a PVC is consumed per one instance(pod). Let assume the initial volume size, which is written in VolumeClaimTemplate, is 100GiB. | |
| 2. These PVCs has expanded to 200GiB according to the growth of DB. | |
| 3. One instance dies. Then a new pod and the corresponding instance is created to fill a vacancy. | |
| 4. The new PVC, which is consumed by the new instance is created. In this case, the size of the new PVC is not 200GiB, but 100GiB. | |
| 5. The data clone to the existing instances to the new instance might fail due to the lack of volume size. | |
| This proposal is to resolve the above-mentioend problem. |
daichimukai
previously approved these changes
Feb 16, 2023
llamerada-jp
dismissed stale reviews from daichimukai and peng225
via
2fbeaf0
Signed-off-by: Yuji Ito <[email protected]> Co-authored-by: Satoru Takeuchi <[email protected]>
llamerada-jp
force-pushed
the
proposal-resize-by-group
branch
from
2fbeaf0 to
c285a1b
Compare
satoru-takeuchi
approved these changes
Feb 17, 2023
peng225
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuji Ito [email protected]