Add CONTRIBUTING.md and update README.md according to CNCF template. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toshikuni Fukaya <[email protected]>
toshipp
requested review from
satoru-takeuchi
and removed request for
llamerada-jp
peng225
reviewed
Jan 31, 2023
README.md
Outdated
|
|
||
| - Kubernetes: 1.25, 1.24, 1.23 | ||
| - CSI drivers that implements the following features | ||
| - [Volume Expansion](https://kubernetes-csi.github.io/docs/volume-expansion.html). |
There was a problem hiding this comment.
Suggested change
| - [Volume Expansion](https://kubernetes-csi.github.io/docs/volume-expansion.html). | |
| - [Volume Expansion](https://kubernetes-csi.github.io/docs/volume-expansion.html) |
|
|
||
| Container images are available on [ghcr.io](https://github.com/topolvm/pvc-autoresizer/pkgs/container/pvc-autoresizer) |
There was a problem hiding this comment.
Is it OK to delete these lines about docker images?
(In topolvm repository, the description about images are remained.
cf. https://github.com/topolvm/topolvm#topolvm)
satoru-takeuchi
previously approved these changes
Jan 31, 2023
There was a problem hiding this comment.
I don't have any additional comments. @peng225 Please merge this PR once you confirmed all comments are reflected.
Signed-off-by: Toshikuni Fukaya <[email protected]>
satoru-takeuchi
approved these changes
Jan 31, 2023
peng225
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.