Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update a note descibing how to maintain go version #167

Merged
merged 1 commit into from
Jan 12, 2023
Merged

update a note descibing how to maintain go version #167

merged 1 commit into from
Jan 12, 2023

Conversation

llamerada-jp
Copy link
Contributor

No description provided.

@llamerada-jp llamerada-jp requested a review from a team as a code owner January 10, 2023 07:49
peng225
peng225 reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@peng225 peng225 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go version is also written in some workflow files.

In our previous discussion, it was decided that these versions are replaced with the reference to the Go version written in go.mod. Will this modification be done in another PR?

@satoru-takeuchi
Copy link
Member

@peng225

Will this modification be done in another PR?

I believe this is addressed by #161

@peng225 peng225 merged commit e45cbfb into main Jan 12, 2023
@peng225 peng225 deleted the maintenance-policy-go branch January 12, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peng225 peng225 peng225 approved these changes

@satoru-takeuchi satoru-takeuchi satoru-takeuchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llamerada-jp @satoru-takeuchi @peng225