-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate probes for PV provisioning and mounting #101
Merged
satoru-takeuchi
merged 10 commits into
main
from
add-separate-metrics-for-pv-provision-and-mounting
Feb 27, 2024
Merged
Separate probes for PV provisioning and mounting #101
satoru-takeuchi
merged 10 commits into
main
from
add-separate-metrics-for-pv-provision-and-mounting
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ec117b
to
ac72651
Compare
8993f3b
to
71b87dd
Compare
5dc0b30
to
a9b5c36
Compare
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
…Probe` Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
Signed-off-by: Ryotaro Banno <[email protected]>
a9b5c36
to
c019c38
Compare
I updated my PR. The changes are: https://github.com/topolvm/pie/compare/a9b5c369798460d423528113786504830e4f809f..c019c385d3bcb19bc66f0eb728adafd5d1d8d86c
|
Signed-off-by: Ryotaro Banno <[email protected]>
…-line arguments instead Signed-off-by: Ryotaro Banno <[email protected]>
1ffc610
to
23a2ee4
Compare
pluser
approved these changes
Feb 27, 2024
LGTM! |
ushitora-anqou
added a commit
that referenced
this pull request
Feb 29, 2024
In pull request #101, we introduced a new custom resource called PieProbe. However, the charts/ and test/e2e/ directories were not synchronized with the auto-generated config/ directory. This patch fixes the above probelm, by copying the latest PieProbe CRD from config/ to charts/ and updating the manifests used in the e2e tests. Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
added a commit
that referenced
this pull request
Feb 29, 2024
In pull request #101, we introduced a new custom resource called PieProbe. However, the charts/ and test/e2e/ directories were not synchronized with the auto-generated config/ directory. This patch fixes the above probelm, by copying the latest PieProbe CRD from config/ to charts/ and updating the manifests used in the e2e tests. Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
added a commit
that referenced
this pull request
Mar 29, 2024
The new provision observer (provision_observer2.go) introduced in #101 tries to remove the owned jobs that is failing for a while, but it doesn't work well because it looks for them by a wrong prefix. This PR fixes the above problem by using constants.MountProbeNamePrefix and constants.ProvisionProbeNamePrefix instead of constants.ProbeNamePrefix when the provision observer looks for the jobs.
ushitora-anqou
added a commit
that referenced
this pull request
Mar 29, 2024
The new provision observer (provision_observer2.go) introduced in #101 tries to remove the owned jobs that is failing for a while, but it doesn't work well because it looks for them by a wrong prefix. This PR fixes the above problem by using constants.MountProbeNamePrefix and constants.ProvisionProbeNamePrefix instead of constants.ProbeNamePrefix when the provision observer looks for the jobs. Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
added a commit
that referenced
this pull request
Apr 1, 2024
The new provision observer (provision_observer2.go) introduced in #101 tries to remove the owned jobs that is failing for a while, but it doesn't work well because it looks for them by a wrong prefix. This PR fixes the above problem by using constants.MountProbeNamePrefix and constants.ProvisionProbeNamePrefix instead of constants.ProbeNamePrefix when the provision observer looks for the jobs. Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
added a commit
that referenced
this pull request
Apr 2, 2024
The new provision observer (provision_observer2.go) introduced in #101 tries to remove the owned jobs that is failing for a while, but it doesn't work well because it looks for them by a wrong prefix. This PR fixes the above problem by using constants.MountProbeNamePrefix and constants.ProvisionProbeNamePrefix instead of constants.ProbeNamePrefix when the provision observer looks for the jobs. Signed-off-by: Ryotaro Banno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current probe checks that both a new provisioning of a PV and its mounting succeed on every Node.
This guarantee is sufficient but not necessary; although mounting an already provisioned PV should succeed on every node, it is sufficient that a new provisioning succeeds on at least one Node.
To address the above issue, the new architecture has the following two types of probes:
In addition, PieProbe custom resource is introduced to group the probes that monitor a StorageClass. Each probe has an owner reference to a PieProbe and is GCed when the referenced PieProbe is deleted. See also issue #50.
This PR introduces the following new metrics:
pie_io_write_latency_on_mount_probe_seconds
pie_io_read_latency_on_mount_probe_seconds
pie_mount_probe_total
pie_performance_on_mount_probe_total
pie_provision_probe_total
Note that old metrics (e.g.,
pie_io_write_latency_seconds
andpie_create_probe_total
) should behave in the same way as before merging this patch.