Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Kahn's algorithm for finding toposort #312

Merged
merged 10 commits into from
Jan 3, 2025
Merged

feat: use Kahn's algorithm for finding toposort #312

merged 10 commits into from
Jan 3, 2025

Conversation

winprn
Copy link
Contributor

@winprn winprn commented Jan 2, 2025 •
edited
Loading

resolve #307
there're some failed test cases because of different order in the topology sort of previous and current implementation

@d-roak d-roak requested review from d-roak and anhnd350309 January 2, 2025 04:58
trungnotchung
trungnotchung reviewed Jan 2, 2025
View reviewed changes
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Outdated Show resolved Hide resolved
trungnotchung
trungnotchung approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JanLewDev
JanLewDev reviewed Jan 2, 2025
View reviewed changes
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
JanLewDev
JanLewDev approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anhnd350309
anhnd350309 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit ce3277b into main Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhnd350309 anhnd350309 anhnd350309 approved these changes

@trungnotchung trungnotchung trungnotchung approved these changes

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use BFS for topological sort instead of DFS
5 participants
@winprn @d-roak @JanLewDev @trungnotchung @anhnd350309