feat: check writer permission before merging #303
Merged
+152
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungnotchung
force-pushed
the
feat/check-writer-permisson
branch
from
ff4711a to
adfb540
Compare
0xaldric
reviewed
Jan 3, 2025
JanLewDev
reviewed
Jan 3, 2025
d-roak
reviewed
Jan 5, 2025
d-roak
reviewed
Jan 5, 2025
trungnotchung
force-pushed
the
feat/check-writer-permisson
branch
from
f95c7f7 to
b33bca9
Compare
d-roak
approved these changes
Jan 5, 2025
hoangquocvietuet
pushed a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a writer permission check before merging vertices.
Update AddWinsSetWithACL because there is no need to check writer permission in the ACL. Updated tests to validate both scenarios. Resolve #302