Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change nodeId to peerId #298

Merged
merged 3 commits into from
Dec 29, 2024
Merged

refactor: change nodeId to peerId #298

merged 3 commits into from
Dec 29, 2024

Conversation

trungnotchung
Copy link
Contributor

@trungnotchung trungnotchung commented Dec 23, 2024 •
edited
Loading

Description:

  • This PR replaces all instances of nodeId with peerId across the codebase to align with libp2p's conventions.

Changes:

  • Replaced nodeId with peerId in code.
  • Updated related tests to reflect the change.

This update improves consistency and clarity in the codebase, closes #297 .

@trungnotchung trungnotchung marked this pull request as ready for review December 23, 2024 16:43
d-roak
d-roak reviewed Dec 23, 2024
View reviewed changes
packages/object/tests/hashgraph.test.ts Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
JanLewDev
JanLewDev approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit d6e3dfa into main Dec 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change nodeId to peerId for Consistency
3 participants
@trungnotchung @d-roak @JanLewDev