feat: remove operations array from the DRP #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanLewDev
requested review from
trungnotchung,
d-roak and
anhnd350309
as code owners
anhnd350309
reviewed
Jan 1, 2025
anhnd350309
reviewed
Jan 1, 2025
d-roak
reviewed
Jan 5, 2025
d-roak
reviewed
Jan 6, 2025
packages/object/src/index.ts
Outdated
Comment on lines
20
to
24
| query_isWriter: (peerId: string) => boolean; | ||
| query_isAdmin: (peerId: string) => boolean; | ||
| grant: (senderId: string, peerId: string, publicKey: string) => void; | ||
| revoke: (senderId: string, peerId: string) => void; | ||
| getPeerKey: (peerId: string) => string | undefined; | ||
| query_getPeerKey: (peerId: string) => string | undefined; |
d-roak
reviewed
Jan 6, 2025
d-roak
reviewed
Jan 6, 2025
d-roak
reviewed
Jan 9, 2025
Comment on lines
+22
to
+24
| query_isWriter: (peerId: string) => boolean; | ||
| query_isAdmin: (peerId: string) => boolean; | ||
| query_getPeerKey: (peerId: string) => string | undefined; |
There was a problem hiding this comment.
Suggested change
| query_isWriter: (peerId: string) => boolean; | |
| query_isAdmin: (peerId: string) => boolean; | |
| query_getPeerKey: (peerId: string) => string | undefined; | |
| query_isAdmin: (peerId: string) => boolean; | |
| query_isWriter: (peerId: string) => boolean; | |
| query_getPeerKey: (peerId: string) => string | undefined; |
nitpicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #257 and closes #310, removing the need to define the operations array by the DRP devs.
Key features:
add(1)is not creating a new vertexquery_*. By convention such functions are not creating operations