Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add reflection #287

Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat(rpc): add reflection #287

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b378c
feat: add reflection service to rpc
winprn Dec 16, 2024
7fafcce
fix: biome
winprn Dec 16, 2024
c9d6a38
fix: update proto stuff
winprn Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
"dependencies": {
"@chainsafe/libp2p-gossipsub": "^14.1.0",
"@grpc/grpc-js": "^1.12.2",
"@grpc/proto-loader": "^0.7.13",
"@grpc/reflection": "^1.0.4",
"@libp2p/interface": "^2.1.3",
"dotenv": "^16.4.5",
"@ts-drp/blueprints": "0.4.0",
Expand Down
11 changes: 11 additions & 0 deletions packages/node/src/rpc/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import * as grpc from "@grpc/grpc-js";
import * as protoLoader from "@grpc/proto-loader";
import * as reflection from "@grpc/reflection";

import path, { dirname } from "node:path";
import { fileURLToPath } from "node:url";
import type { ServerUnaryCall, sendUnaryData } from "@grpc/grpc-js";
import { type DRPNode, log } from "../index.js";
import { DRPRpcService } from "../proto/drp/node/v1/rpc_grpc_pb.js";
Expand All @@ -11,6 +15,9 @@ import type {
UnsubscribeDRPRequest,
UnsubscribeDRPResponse,
} from "../proto/drp/node/v1/rpc_pb.js";
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
const PROTO_PATH = path.resolve(__dirname, "../proto/topology/node/rpc.proto");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
const PROTO_PATH = path.resolve(__dirname, "../proto/topology/node/rpc.proto");
const protoPath = path.resolve(dirname(fileURLToPath(import.meta.url)), "../proto/topology/node/rpc.proto");

move this inside the init function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


export function init(node: DRPNode) {
function subscribeDRP(
Expand Down Expand Up @@ -70,7 +77,11 @@ export function init(node: DRPNode) {
callback(null, response);
}

const packageDefinition = protoLoader.loadSync(PROTO_PATH);
const reflectionService = new reflection.ReflectionService(packageDefinition);

const server = new grpc.Server();
reflectionService.addToServer(server);
d-roak marked this conversation as resolved.
Show resolved Hide resolved
server.addService(DRPRpcService, {
subscribeDRP,
unsubscribeDRP,
Expand Down
17 changes: 17 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading