Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CROState to vertices; partial linearisation #263

Merged
merged 38 commits into from
Dec 3, 2024
Merged

feat: add CROState to vertices; partial linearisation #263

merged 38 commits into from
Dec 3, 2024

Conversation

JanLewDev
Copy link
Contributor

@JanLewDev JanLewDev commented Nov 18, 2024 •
edited
Loading

Closes #259, closes #258

@JanLewDev JanLewDev changed the title feat: add CROState to vertices (WIP) feat: add CROState to vertices Nov 22, 2024
@JanLewDev JanLewDev marked this pull request as ready for review November 22, 2024 11:54
d-roak
d-roak requested changes Nov 25, 2024
View reviewed changes
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/linearize/pairSemantics.ts Outdated Show resolved Hide resolved
trungnotchung
trungnotchung reviewed Nov 25, 2024
View reviewed changes
packages/object/src/hashgraph/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
@JanLewDev JanLewDev changed the title feat: add CROState to vertices feat: add CROState to vertices; partial linearisation Nov 25, 2024
@trungnotchung trungnotchung marked this pull request as draft November 26, 2024 06:39
@trungnotchung trungnotchung marked this pull request as ready for review November 30, 2024 04:09
d-roak
d-roak reviewed Dec 3, 2024
View reviewed changes
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/src/index.ts Outdated Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Show resolved Hide resolved
packages/object/tests/hashgraph.test.ts Outdated Show resolved Hide resolved
d-roak
d-roak approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 90d554e into main Dec 3, 2024
12 checks passed
@d-roak d-roak deleted the feat/vertex-state branch December 5, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungnotchung trungnotchung trungnotchung left review comments

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertex state Partial linearisation
3 participants
@JanLewDev @d-roak @trungnotchung