refactor: codebase check #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d-roak
commented
Nov 18, 2024
•
d-roak
commented
- rename topology protocol/CRO to DRP
- rm unused stuff
- apply linter suggestions for protobuf
- add biome to package.json
- make drp message protocol string for libp2p global (Enhancement : Make protocol string global #244)
- added config objects in the packages that it was missing
- use the same log pattern everywhere
- build dynamically all examples in the CI
JanLewDev
reviewed
Dec 2, 2024
| import { NetworkPb } from "@ts-drp/network"; | ||
| import { type DRPObject, ObjectPb } from "@ts-drp/object"; | ||
| import { drpMessagesHandler, drpObjectChangesHandler } from "./handlers.js"; | ||
| import { type DRPNode, log } from "./index.js"; | ||
|
|
||
| /* Object operations */ | ||
| enum OPERATIONS { |
There was a problem hiding this comment.
Below is unchanged code still with cro
Co-authored-by: Jan Lewandowski <[email protected]>
Co-authored-by: Jan Lewandowski <[email protected]>
Co-authored-by: Jan Lewandowski <[email protected]>
Co-authored-by: Jan Lewandowski <[email protected]>
trungnotchung
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.