Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing vertex dependencies issue #247

Merged
merged 26 commits into from
Nov 16, 2024
Merged

Fixing vertex dependencies issue #247

merged 26 commits into from
Nov 16, 2024

Conversation

elielnfinic
Copy link
Contributor

This PR fixes issue #185
When a peer joins a CRO, it synchronizes the two peers vertex before merging them.

elielnfinic
elielnfinic commented Nov 12, 2024
View reviewed changes
Copy link
Contributor Author

@elielnfinic elielnfinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know some code are weird on try and catches, please let me know what you think.

@elielnfinic elielnfinic marked this pull request as ready for review November 12, 2024 13:27
d-roak
d-roak requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code quality is pretty poor. Let's try to make it cleaner

packages/node/src/handlers.ts Outdated Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
packages/object/src/hashgraph/index.ts Show resolved Hide resolved
@elielnfinic elielnfinic marked this pull request as draft November 14, 2024 06:03
@elielnfinic elielnfinic marked this pull request as ready for review November 14, 2024 07:36
@elielnfinic elielnfinic marked this pull request as draft November 14, 2024 08:08
@elielnfinic elielnfinic marked this pull request as ready for review November 14, 2024 10:23
d-roak
d-roak requested changes Nov 14, 2024
View reviewed changes
packages/node/src/handlers.ts Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
packages/node/src/handlers.ts Outdated Show resolved Hide resolved
trungnotchung
trungnotchung approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JanLewDev
JanLewDev approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit e4a1ecf into topology-foundation:main Nov 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungnotchung trungnotchung trungnotchung approved these changes

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elielnfinic @d-roak @JanLewDev @trungnotchung