Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lost of CRO context in resolveConflicts #243

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: lost of CRO context in resolveConflicts #243

merged 1 commit into from
Nov 7, 2024

Conversation

cwkang1998
Copy link
Contributor

Per title, fix issue #242

elielnfinic
elielnfinic approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@elielnfinic elielnfinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that context can be lost at certain time. Good to pass the cro in bind.

d-roak
d-roak approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@d-roak d-roak merged commit dd7ce6a into topology-foundation:main Nov 7, 2024
7 checks passed
@d-roak d-roak mentioned this pull request Nov 7, 2024
Closed
d-roak pushed a commit that referenced this pull request Nov 13, 2024
@cwkang1998 @d-roak
fix: lost of CRO context in resolveConflicts (#243)
5f090f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elielnfinic elielnfinic elielnfinic approved these changes

@d-roak d-roak d-roak approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwkang1998 @d-roak @elielnfinic