Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor perms and change output summaries #237

Merged
merged 15 commits into from
Nov 6, 2024
Merged

ci: refactor perms and change output summaries #237

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4831f99
add pull request on the benchmark flow
d-roak Nov 6, 2024
953de0c
just skip fetch on push
d-roak Nov 6, 2024
30cd2f6
add pr write perms
d-roak Nov 6, 2024
0e99cea
tweak permissions
d-roak Nov 6, 2024
323ead4
restore content write permission
d-roak Nov 6, 2024
7400367
Merge branch 'main' into test
d-roak Nov 6, 2024
e641162
temporarily write all
d-roak Nov 6, 2024
6003200
add pr target
d-roak Nov 6, 2024
8d6229f
refactor permissions
d-roak Nov 6, 2024
198104f
add edited to target
d-roak Nov 6, 2024
377b646
rm specifying types
d-roak Nov 6, 2024
bbd517f
change to comment on alert and add summary
d-roak Nov 6, 2024
b5c1d99
revert to on pr
d-roak Nov 6, 2024
720ed10
test lower threshold
d-roak Nov 6, 2024
78a5615
rm useless stuff-
d-roak Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ on:
permissions:
pages: write
id-token: write
pull-requests: write
contents: write

jobs:
benchmark:
name: Run benchmark
permissions:
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -26,8 +24,6 @@ jobs:
pnpm install --no-frozen-lockfile
cd packages/object
pnpm run benchmark
# possible lockfile and version.ts changes
git stash
- name: Set cache dir
uses: actions/cache@v4
Expand All @@ -44,7 +40,8 @@ jobs:
output-file-path: packages/object/benchmark-output.txt
alert-threshold: "200%"
fail-on-alert: true
comment-always: true
comment-on-alert: ${{ github.event_name == 'push' }}
summary-always: true
gh-pages-branch: main
skip-fetch-gh-pages: ${{ github.event_name == 'push' }}
benchmark-data-dir-path: ./cache/benchmarks
Expand Down