Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logging package #206

Merged
merged 15 commits into from
Oct 29, 2024
Merged

feat: logging package #206

merged 15 commits into from
Oct 29, 2024

Conversation

winprn
Copy link
Contributor

@winprn winprn commented Oct 28, 2024 •
edited
Loading

This package contains a implementation of BrowserTransport for browser usage.
Ref: BrowserConsole

d-roak
d-roak reviewed Oct 28, 2024
View reviewed changes
packages/logger/asconfig.json Outdated Show resolved Hide resolved
packages/logger/package.json Outdated Show resolved Hide resolved
packages/logger/package.json Outdated Show resolved Hide resolved
packages/logger/package.json Outdated Show resolved Hide resolved
packages/logger/src/browser.ts Outdated Show resolved Hide resolved
packages/logger/tsconfig.json Outdated Show resolved Hide resolved
packages/logger/tsconfig.json Outdated Show resolved Hide resolved
@winprn
Copy link
Contributor Author

winprn commented Oct 29, 2024

For the current logging in package/network, here're some screenshots about the change:

Browser

image

CLI

image

@d-roak d-roak changed the title Feat: Logging Package feat: logging package Oct 29, 2024
@winprn winprn marked this pull request as ready for review October 29, 2024 06:58
d-roak
d-roak approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 25e8f24 into main Oct 29, 2024
7 checks passed
@winprn winprn deleted the logger branch October 29, 2024 08:59
trungnotchung pushed a commit that referenced this pull request Oct 30, 2024
@winprn @trungnotchung
feat: logging package (#206)
c2a6218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winprn @d-roak