improv: local bootstrap node set up w/ example #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating my branch to the latest changes
d-roak
reviewed
Oct 21, 2024
packages/network/src/node.ts
Outdated
Comment on lines
67
to
86
| const bootstrap_nodes_list = this._config?.bootstrap_peers | ||
| ? this._config.bootstrap_peers | ||
| : [ | ||
| "/dns4/relay.droak.sh/tcp/443/wss/p2p/Qma3GsJmB47xYuyahPZPSadh1avvxfyYQwk8R3UnFrQ6aP", | ||
| ]; | ||
|
|
||
| const _pubsubPeerDiscovery = pubsubPeerDiscovery({ | ||
| interval: 10_000, | ||
| topics: ["topology::discovery"], | ||
| }); | ||
|
|
||
| const peer_discovery = bootstrap_nodes_list.length | ||
| ? [ | ||
| _pubsubPeerDiscovery, | ||
| bootstrap({ | ||
| list: bootstrap_nodes_list, | ||
| }), | ||
| ] | ||
| : [_pubsubPeerDiscovery]; | ||
|
|
There was a problem hiding this comment.
If you disconnect WiFi and the relay.droak.sh is still in the list of bootstrap_peers, when the relay is run it produces an issue.
There was a problem hiding this comment.
what do you mean? this change is restructuring code, is not changing logic
There was a problem hiding this comment.
When there is no bootstrap node list, I shouldn't have the bootstrap({list : []}) property.
If it is in the object, I am getting the following error :
@topology-foundation/[email protected] cli /Users/monordi/apps/topology/ts-topology/packages/node
> tsx ./src/run.ts "relay" "--config" "configs/local-bootstrap.json"
/Users/monordi/apps/topology/ts-topology/node_modules/.pnpm/@[email protected]/node_modules/@libp2p/bootstrap/src/index.ts:98
throw new Error('Bootstrap requires a list of peer addresses')
^
Error: Bootstrap requires a list of peer addresses```
That's why I created the condition to check if I have bootstrap nodes in my config. If not, pass the `peer-discovery` not having the bootstrap property.
d-roak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the Developer Experience (DX) for the local environment. It streamlines the process of running a topology bootstrap on a local device or network, making it easier to connect peers efficiently.
Currently, the changes are applied to the chat example, but if approved, I can extend this implementation to the other examples as well.
Summary of Changes
Here are the edited files :
Here are the created files :
Feel free to let me know if there are any adjustments or suggestions. Once approved, I can proceed with applying the same improvements to the other examples.