Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hg deps bug #161

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: hg deps bug #161

merged 2 commits into from
Sep 18, 2024

Conversation

d-roak
Copy link
Member

@d-roak d-roak commented Sep 18, 2024

fixes #160

guiltygyoza
guiltygyoza approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@guiltygyoza guiltygyoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

since linearizeOperations doesn't care about the operation carried by root vertex, we can also set rootHash to empty string.

@d-roak d-roak merged commit 6b80e2f into main Sep 18, 2024
7 checks passed
@d-roak d-roak deleted the fix/hg-deps branch September 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guiltygyoza guiltygyoza guiltygyoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with invalid dependencies in the hash graph
2 participants
@d-roak @guiltygyoza