Skip to content

Commit

Permalink
ci: don't fail on alert the benchmark on push
Browse files Browse the repository at this point in the history
  • Loading branch information
d-roak committed Dec 6, 2024
1 parent 3a45ee4 commit eb4ab71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
output-file-path: packages/object/benchmark-output.txt
alert-threshold: "130%"
fail-on-alert: true
fail-on-alert: ${{ github.event_name != 'push' }}
comment-on-alert: ${{ github.event_name == 'push' }}
summary-always: true
gh-pages-branch: main
Expand Down

1 comment on commit eb4ab71

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Benchmark.js Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: eb4ab71 Previous: 76d22c9 Ratio
Create HashGraph with 1000 vertices 10.98 ops/sec (±1.51%) 246 ops/sec (±0.36%) 22.40
Create 2 DRP Objects (1000 vertices each) and Merge 0.51 ops/sec (±3.27%) 0.98 ops/sec (±3.13%) 1.92

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.