This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
feat: emit state updates for calling the pub sub grp #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d-roak
reviewed
Jul 3, 2024
Comment on lines
+11
to
+16
| export const playerPosition = writable<Player>({ | ||
| id: "", | ||
| position: new Vector3(0, 10000, 20005), | ||
| rotation: new Euler(0, 0, 0, "XYZ"), | ||
| state: "idle", | ||
| }); |
There was a problem hiding this comment.
might be confusing the naming here, the const should either be called player or playerData, since the position is one of the subfields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.