Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support VSCodium in the step VSCode #788

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support VSCodium in the step VSCode #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a43a45
feat: support VSCodium in the step VSCode
SteveLauC May 6, 2024
0e31cf7
style: fmt
SteveLauC May 6, 2024
a0d1ba2
feat: alias support in configuration file
SteveLauC May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ pub enum Step {
Vagrant,
Vcpkg,
Vim,
#[serde(alias="vscodium")]
Vscode,
Waydroid,
Winget,
Expand Down
2 changes: 1 addition & 1 deletion src/steps/generic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@
return Err(SkipStep(String::from("Should not run in WSL")).into());
}

let vscode = require("code")?;
let vscode = require("code").or_else(|_| require("codium"))?;

Check warning on line 357 in src/steps/generic.rs

View check run for this annotation

Codecov / codecov/patch

src/steps/generic.rs#L357 

Added line #L357 was not covered by tests

// Vscode has update command only since 1.86 version ("january 2024" update), disable the update for prior versions
// Use command `code --version` which returns 3 lines: version, git commit, instruction set. We parse only the first one
Expand Down
Loading